Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/Separate date and time picker #6423

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat/Separate date and time picker #6423

wants to merge 6 commits into from

Conversation

GVodyanov
Copy link
Contributor

Fix #6385

@GVodyanov GVodyanov added the 2. developing Work in progress label Oct 14, 2024
@GVodyanov GVodyanov self-assigned this Oct 14, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 23.59%. Comparing base (b20a767) to head (578f0b9).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Shared/TimePicker.vue 0.00% 19 Missing ⚠️
src/store/calendarObjectInstance.js 0.00% 10 Missing and 4 partials ⚠️
...ents/Editor/Properties/PropertyTitleTimePicker.vue 0.00% 7 Missing ⚠️
src/mixins/EditorMixin.js 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6423      +/-   ##
============================================
+ Coverage     23.53%   23.59%   +0.06%     
  Complexity      454      454              
============================================
  Files           247      247              
  Lines         11705    11649      -56     
  Branches       2213     2195      -18     
============================================
- Hits           2755     2749       -6     
+ Misses         8629     8576      -53     
- Partials        321      324       +3
Flag Coverage Δ
javascript 15.14% <0.00%> (+0.07%) ⬆️
php 59.42% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala will be requested when the pull request is marked ready for review miaulalala is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny will be requested when the pull request is marked ready for review st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld will be requested when the pull request is marked ready for review tcitworld is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@GVodyanov GVodyanov

Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Date/Time selector to be more intuitive.
1 participant
@GVodyanov